Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support inlined or aliased structs as type enum variants #1535

Merged
merged 1 commit into from
May 18, 2024
Merged

fix: support inlined or aliased structs as type enum variants #1535

merged 1 commit into from
May 18, 2024

Conversation

worstell
Copy link
Contributor

small changes + fixes preempting the refactor

fixes #1531, #1527, #1496

@worstell worstell requested a review from alecthomas as a code owner May 18, 2024 04:36
@worstell worstell requested review from a team and wesbillman and removed request for a team May 18, 2024 04:36
@ftl-robot ftl-robot mentioned this pull request May 18, 2024
Open
@worstell worstell force-pushed the worstell/20240517-support-aliased-and-inlined-enum-variants branch from f7f3fdc to 815f78e Compare May 18, 2024 04:38
alecthomas
alecthomas approved these changes May 18, 2024
View reviewed changes
Copy link
Collaborator

@alecthomas alecthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@worstell worstell force-pushed the worstell/20240517-support-aliased-and-inlined-enum-variants branch from 815f78e to e8b39ea Compare May 18, 2024 04:55
@worstell worstell force-pushed the worstell/20240517-support-aliased-and-inlined-enum-variants branch from e8b39ea to 2d46b2a Compare May 18, 2024 04:56
@worstell worstell merged commit 21df777 into main May 18, 2024
24 checks passed
@worstell worstell deleted the worstell/20240517-support-aliased-and-inlined-enum-variants branch May 18, 2024 05:00
matt2e added a commit that referenced this pull request May 22, 2024
@matt2e
Revert "fix: support inlined or aliased structs as type enum variants (…
62d307d 
…#1535)"

This reverts commit 21df777.

# Conflicts:
#	go-runtime/compile/schema_test.go
#	go-runtime/compile/testdata/failing/failing.go
This was referenced May 22, 2024
Merged
Closed
matt2e added a commit that referenced this pull request May 23, 2024
@matt2e
fix: allow subpackage types (#1558)
ad82760 
Reverts two PRs:
- #1530
- #1535

This is a blunt fix to unblock based on our priorities. We should
revisit #1535 again later
matt2e pushed a commit that referenced this pull request May 23, 2024
@worstell @matt2e
fix: support inlined or aliased structs as type enum variants (#1535)
6968ebd 
small changes + fixes preempting the refactor

fixes #1531, #1527, #1496
@matt2e matt2e mentioned this pull request May 23, 2024
Merged
matt2e added a commit that referenced this pull request May 23, 2024
@matt2e @worstell
fix: support inlined or aliased structs (#1563)
8d0d6c8 
Un-reverting #1535 by @worstell 
small changes + fixes preempting the refactor

fixes #1531,
#1527,
#1496

Co-authored-by: worstell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecthomas alecthomas alecthomas approved these changes

@wesbillman wesbillman Awaiting requested review from wesbillman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support aliased and inlined struct type enum variants
2 participants
@worstell @alecthomas